Skip to content

Conversation

@wilriker
Copy link
Contributor

No description provided.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __main__.py25250%3–66
   data_vector.py115199%42
   datatypes.py399299%57, 127
   discover.py58198%63
luxtronik/cfi
   interface.py1491391%79–92, 241–242, 247
   parameters.py31197%49
luxtronik/scripts
   __init__.py35586%7–16, 51
   discover_shi.py60600%8–98
   dump_cfi.py14657%18–25, 29
   dump_shi.py15660%21–28, 32
   performance_shi.py63630%7–89
   update_screen.py1058222%6, 20–41, 46–48, 51–61, 64, 70–75, 78, 81–85, 88–92, 95–97, 100–103, 106–111, 115–116, 119–126, 129–136
   watch_cfi.py321650%36–47, 50–56, 60
   watch_shi.py331652%38–49, 52–58, 62
luxtronik/shi
   contiguous.py136299%265–266
TOTAL239929988% 

Tests Skipped Failures Errors Time
380 0 💤 0 ❌ 0 🔥 29.156s ⏱️

@kbabioch
Copy link
Collaborator

Thank you for your contribution @wilriker . Not sure if and how I can verify this, so I guess we can only merge and see if anyone complains (in case the definitions are wrong).

Any complaints, especially from @Guzz-T, who has worked a lot on this in the recent past?

@wilriker
Copy link
Contributor Author

wilriker commented Jan 26, 2026

Sorry, I should have given a few comments here. I was actually looking for the parameter/calculation that would give me the max outdoor temp when the heat pump stops working. I did find the min temp but no corresponding max (maybe because max cannot be changed but min can?!).
So I started looking through the available values and found some Unknown values that clearly resembled temperatures including the one for max outdoor temp. Compiled the changes locally, looked fine to me so I created this PR.

All of those values are currently set to read-only so changing unit and scaling should not hurt but only improve things.

@kbabioch kbabioch merged commit 73e09ff into Bouni:main Jan 27, 2026
4 checks passed
@Guzz-T
Copy link
Contributor

Guzz-T commented Jan 27, 2026

All values for my heat pump are constant with default values. Therefore, I cannot verify this. The values themselves appear plausible in relation to the existing names.

@wilriker
Copy link
Contributor Author

I think (I haven't tried myself, though) if you modify minimum working temp (needs "Installer" mode) that should reflect at least in parameter 92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants