Show server-down page when server is unavailable#2853
Merged
Conversation
When the server doesn't respond (network errors, 5xx status codes, timeouts), show a user-friendly error page directing users to report the issue in the Telegram chat instead of the generic "oooops..." page. Closes #2420 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move translations loading before API calls so server-down page renders with translated text instead of raw keys - Remove AbortError detection (can be user-initiated navigation) - Accept unknown type in isServerError with runtime type guard - Remove unused server_down.telegram_link translation key - Add test for non-object error values Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Frontend test coverage: 70.98% (+0.12% compared to 70.86% on base) |
|
Frontend test coverage: 70.9% (+0.01% compared to 70.89% on base) |
Extract ErrorPage component from error route template so it can be tested directly. Add 7 integration tests verifying ServerDown renders for server errors (500, 503, network) and generic error renders for client errors (404, strings, Error objects). Also test rel attribute on Telegram link. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Frontend test coverage: 70.9% (+0.01% compared to 70.89% on base) |
|
Frontend test coverage: 70.63% (-0.21% compared to 70.84% on base) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isServerErrorutility to detect server/network failures (WarpDrive FetchError, TypeError from fetch, AbortError, 5xx status codes)Closes #2420
Test plan
isServerErrorutility covering all error types (5xx, network errors, timeouts, client errors)ServerDowncomponent (renders title, message, Telegram link)🤖 Generated with Claude Code