refactor: extract headphones UI into dedicated component#2858
Merged
Conversation
|
Frontend test coverage: 70.89% (+0.14% compared to 70.75% on base) |
lifeart
force-pushed
the
refactor/extract-headphones-component
branch
from
aee0393 to
af80b42
Compare
|
Frontend test coverage: 70.89% (+0.14% compared to 70.75% on base) |
lifeart
force-pushed
the
refactor/extract-headphones-component
branch
from
af80b42 to
b15a666
Compare
|
Frontend test coverage: 70.94% (+0.15% compared to 70.79% on base) |
- Extract headphone CRUD logic from profile into app/components/ui/headphones - Use Ui::Button component instead of raw <button> elements - Internationalize headphone type labels (en-us + ru-ru) - Add 10 integration tests for the new component - Profile component reduced by ~130 lines Inspired by #2490 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lifeart
force-pushed
the
refactor/extract-headphones-component
branch
from
b15a666 to
1abbf49
Compare
|
Frontend test coverage: 70.87% (+0.08% compared to 70.79% on base) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the headphones management UI from the profile component into a standalone
ui/headphonescomponent, adapted from the approach in #2490.Changes
ui/headphonescomponent — all headphone CRUD logic (load, add, delete) extracted from profileUi::Buttonusage — replaces raw<button>elements with the existing component<UiHeadphones />instead of inline headphone logicTest results
Inspired by #2490