Skip to content

Conversation

@robertleeplummerjr
Copy link
Contributor

A GIF or MEME to give some spice of the internet

Description

Removal of opencollective as a dependency. If people want to donate, they shouldn't be badgered to do so, they should ask they companies they work for to do it, and the companies should do it.

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

While it is nice to let others know they can donate, I don't believe ads by way of the terminal are the way to do it.  Ty for catching!.

Fixes issue #269
@robertleeplummerjr robertleeplummerjr merged commit d9b853e into v1.x Aug 30, 2018
@robertleeplummerjr robertleeplummerjr deleted the 269-ads-removal branch August 30, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants