110 feature preprocessing functionality#125
Conversation
Update toml structure to new poetry standard
Replace magic strings with constants
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project configuration from Poetry-specific format to a hybrid setup that uses both [tool.poetry] and PEP 621 [project] metadata sections. It also adds a new preprocessing module with functions for different BraTS challenge preprocessing pipelines.
- Converts dependency declarations from
[tool.poetry.dependencies]to[project]dependencies - Moves author format from Poetry-style strings to PEP 621 dictionary format
- Adds comprehensive preprocessing functionality with challenge-specific pipeline selection
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pyproject.toml | Migrates project metadata and dependencies from Poetry format to PEP 621 standard while maintaining Poetry configuration for build system |
| brats/preprocessing.py | Introduces new preprocessing module with challenge-specific preprocessing functions that wrap brainles_preprocessing library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neuronflow
left a comment
neuronflow
left a comment
There was a problem hiding this comment.
Very cool work @MarcelRosier,
I love how you came up with the challenge-specific preprocessing selection in
preprocess_for_challenge!
|
Should we default to install with or without preprocessing? This option needs to be documented in the I suggest to default to installation with P but to give users the option to skip it. |
neuronflow
left a comment
neuronflow
left a comment
There was a problem hiding this comment.
installation options need to be documented in readme
Enhance import error msg
I opted for installing just the base package by default since it's a lot more lightweight (also I'm not sure how to elegantly implement the other way, feel free to suggest something if you think this is needed). Installation documentation is added to the readme |
Adds methods for preprocessing
Docs in Readme/ docs should follow in #115