This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Conversation
Signed-off-by: neuronflow <florian.kofler@tum.de>
Contributor
Author
|
@sarthakpati Probably we need to move more of the logging logic to the methods and out of the init? |
Contributor
Author
|
This also leads to the discussion of whether we want a separate resampler / transformator object. |
Collaborator
|
I feel this is a quality of life change, and we can put it off till we have the other things finalized. |
Contributor
Author
no, this currently blocks the integration in the preprocessing pipeline :) |
neuronflow
requested review from
IsraMekki0
and removed request for
sarthakpati
Contributor
Author
|
@format-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.