Skip to content

feat: Create GoogleSheetImport (Fixes #646)#660

Merged
skxeve merged 3 commits intomasterfrom
feature/646-gsheet-importer
Mar 31, 2026
Merged

feat: Create GoogleSheetImport (Fixes #646)#660
skxeve merged 3 commits intomasterfrom
feature/646-gsheet-importer

Conversation

@skxeve
Copy link
Copy Markdown
Collaborator

@skxeve skxeve commented Mar 25, 2026

Brief

Fixes #646

Points to Check

  • Any unexpected impact
  • The overall quality is trending positively

Test

Confirmed

Pass ALL CI.

Review Limit

  • Write review limit on pull request title.

@skxeve skxeve self-assigned this Mar 25, 2026
@skxeve skxeve added the feat A new feature label Mar 25, 2026
@skxeve skxeve requested a review from x-chi March 31, 2026 06:44
@x-chi
Copy link
Copy Markdown
Collaborator

x-chi commented Mar 31, 2026

[nits]
(1) Error due to cell limit (Google API limitation)
Google Sheets has a limit of "10 million cells" for a single spreadsheet.

Risk: If the CSV file you are trying to import is very large (e.g., hundreds of thousands of rows x tens of columns), an error will be returned from the Google API the moment you execute worksheet.update, and the process will stop completely.
https://support.google.com/drive/answer/37603

(2) Handling CSV files without headers
Currently, df.columns.values.tolist() is forcibly written as the header.

Concern: There is no has_header argument like in other load modules such as BigQueryWrite. If a CSV file without headers is read, the data in the first row may be treated as the header (column names).

Copy link
Copy Markdown
Collaborator

@x-chi x-chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only commented on the contents of nits, but that's fine. Thank you for implementing it.

@skxeve
Copy link
Copy Markdown
Collaborator Author

skxeve commented Mar 31, 2026

@x-chi
Thanks for the review. I've added a note to the class comments.

@skxeve skxeve merged commit 28733bc into master Mar 31, 2026
10 checks passed
@skxeve skxeve deleted the feature/646-gsheet-importer branch March 31, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: CSV import to Google Sheets

2 participants