Conversation
|
[imo] Handling both modes in one class makes the validation logic quite complex, so it might be cleaner to split this into two separate classes (like |
Tsuyoposon
left a comment
There was a problem hiding this comment.
My comments are just suggestions, so I'm approving this.
|
@Tsuyoposon However, in cliboa, it has been a long-standing practice to consolidate related modes into a single class rather than splitting them (e.g., #665), and I implemented this feature in accordance with that policy. In my view, the complexity of the arguments in CsvConcat stems more from the existence of Since this PR is already approved and deprecation is out of scope for this task, I will proceed with the merge as is. I'll make sure to open a separate issue for the deprecation so we don't lose track of it. |
Brief
Added group mode to CsvConcat.
It uses regex to group files by their naming conventions and merges them group-by-group.
Points to Check
Test
Confirmed
Pass ALL unit test.
Review Limit
Write review limit on pull request title.