Deprecate src_filenames in CsvConcat#667
Merged
skxeve merged 6 commits intoBrainPad:masterfrom Apr 3, 2026
Merged
Conversation
…oncat-src-filenames deprecate src_filenames in CsvConcat
skxeve
requested changes
Apr 2, 2026
Collaborator
skxeve
left a comment
skxeve
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you please address the comments above?
| else: | ||
| _warn_deprecated( | ||
| "CsvConcat.src_filenames", | ||
| end_version="3.0", |
Collaborator
There was a problem hiding this comment.
Since the next version will be 3.1.x, the deprecation will take effect in version 3.1 or later.
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging. Addressed this issue.
| files = self.get_src_files() | ||
| else: | ||
| _warn_deprecated( | ||
| "CsvConcat.src_filenames", |
Collaborator
There was a problem hiding this comment.
Since CsvConcat.src_filenames is not defined, please change it to CsvConcat.Arguments.src_filenames. Please also follow this format for the 'instead' description.
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging. Fixed this.
…oncat-src-filenames Correct End Version, Deprecated, Instead Arguments
…oncat-src-filenames Update version in csv_concat.md file
Contributor
Author
|
Could you please review the PR now? |
skxeve
approved these changes
Apr 3, 2026
Collaborator
skxeve
left a comment
skxeve
left a comment
There was a problem hiding this comment.
LGTM! Thank you for addressing my comments and fixing the issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
Deprecate src_filenames parameter in CsvConcat to pave the way for its removal in v4.0.
src_filenames is redundant since src_pattern already covers file selection, is unique to CsvConcat (inconsistent with the rest of the
ecosystem), and adds unnecessary complexity to the validation logic. When src_filenames is used, a DeprecationWarning is now emitted
pointing users to src_pattern instead.
Points to Check
(ObjectStore, cliboa.util.helper, etc.)
Test
Confirmed
Review Limit
Fixes #666