fix: referencing symbol arguments.(Fixes #670)#671
Conversation
|
Thank you for implementing this. I would like to check the following: Potential breaking change regarding dynamic attribute overwriting In the previous implementation, symbol resolution seemed to point to the BaseStep instance at runtime. However, this PR changes the logic to resolve arguments during the build phase using the static _step_model_map. If a user has a custom step that dynamically modifies its own attributes during the execute method (for example, updating a file path or a memo field based on runtime logic), those changes will no longer be reflected in subsequent steps that reference it via symbol. The subsequent steps will instead receive the initial values defined in the scenario file. I would like to clarify the following points: Is this change in behavior an intentional "breaking change" to enforce the use of context (put_to_context/get_from_context) for dynamic data passing? If this is a recommended architectural shift, should we provide a more explicit warning or documentation note for users who might experience silent failures when their dynamic updates are no longer propagated? |
|
@x-chi The behavior you mentioned was changed in the v2.x to v3.x migration, not by this PR. This PR is strictly for fixing the bug in #670. |
x-chi
left a comment
There was a problem hiding this comment.
Thank you for implementing it.
There were no issues with the comments.
Brief
Fixes #670
Points to Check
Test
Confirmed
(Write content to confirm / Reason why not necessary)
Pass ALL CI.
Review Limit
Write review limit on pull request title.