feat: improve CsvConcat logging by removing misleading warning#674
Merged
skxeve merged 2 commits intoBrainPad:masterfrom Apr 10, 2026
Merged
Conversation
skxeve
requested changes
Apr 9, 2026
| for file in self.args.src_filenames: | ||
| files.append(os.path.join(self.args.src_dir, file)) | ||
|
|
||
| self.logger.info(f"{len(files)} input files are found.") |
Collaborator
There was a problem hiding this comment.
Please move this after the exception check for 0 files, as the exception already generates an error log within the cliboa framework.
Author
There was a problem hiding this comment.
Fixed! Moved the log statement after the exception check.
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673.
This PR improves the logging in
CsvConcatby removing the misleading warning "Two or more input files are required" when only one file is provided. Since the process continues successfully with one file, a warning was inappropriate. An INFO level log has been added to explicitly state the number of input files being processed.