fix: rebase POS sales invoice GL entries on ERPNext 16#209
Open
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Open
fix: rebase POS sales invoice GL entries on ERPNext 16#209my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Conversation
Contributor
Author
|
Staging validation on ERPNext 16.11.0 showed the immediate root cause for the unpaid submitted invoice path was payment rows being overwritten during draft creation in The confirmed fix is now in PR #215, which preserves cashier-entered payment rows across Closing or deprioritizing this PR in favor of #215 would avoid parallel review on the wrong root-cause path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
POSNext's override had drifted from ERPNext 16 core and could produce incorrect paid/outstanding behavior on submitted POS invoices.
Testing
Refs #191