Merged
Conversation
TinyMCE upgrade from 4 to 6 requires a good bit of changes to this plugin. Also cleans up some code formatting to what we use now.
sntran
reviewed
Jan 23, 2024
| var i = 14 | ||
|
|
||
| while (i--) uri[o.key[i]] = m[i] || '' | ||
| function parseUri(str) { |
Member
There was a problem hiding this comment.
Browsers now have the URL construct that can be used to parse. And there is URLSearchParams that can give us the query string. Maybe we switch to that instead?
sntran
approved these changes
Jan 23, 2024
Removes old code to grab search params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinyMCE upgrade from 4 to 6 requires a good bit of changes to this plugin. Also cleans up some code formatting to what we use now.
This should stay in Draft until we get the TinyMCE Update merged into master branch of SAM. Otherwise SAM may point to this v6 compatible plugin that will be broke in v4.