Skip to content

spell haste#390

Merged
BreakBB merged 13 commits intoBreakBB:masterfrom
Alessandro-Barbieri:spell-haste
Feb 13, 2026
Merged

spell haste#390
BreakBB merged 13 commits intoBreakBB:masterfrom
Alessandro-Barbieri:spell-haste

Conversation

@Alessandro-Barbieri
Copy link
Copy Markdown
Contributor

@Alessandro-Barbieri Alessandro-Barbieri commented Dec 24, 2025

@Alessandro-Barbieri Alessandro-Barbieri marked this pull request as ready for review December 25, 2025 16:18
Copy link
Copy Markdown
Owner

@BreakBB BreakBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot: A migration is required for this to actually work.

The hasteRating and hasteBonus stats have a isTbcOnly = true in the Profile.lua. That needs to be removed there and in a proper migration as well (setting it to nil).

Copy link
Copy Markdown
Owner

@BreakBB BreakBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now only a Migration is needed so users actually see the haste values after an update.

Comment thread Modules/Data/SpellDamage.lua Outdated
@BreakBB BreakBB merged commit 63c48f3 into BreakBB:master Feb 13, 2026
3 checks passed
@Alessandro-Barbieri Alessandro-Barbieri deleted the spell-haste branch February 13, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants