Calculate wind_offshore curtailment

[danielolsen]

Purpose

Enable calculation of curtailment time series for 'wind_offshore' plants.

What is the code doing

In curtailment.py:

• we add a reference that 'wind_offshore' profiles are obtained by calling get_wind().
• we refactor calculate_curtailment_time_series() so that is calls get_wind() and/or get_solar() as necessary, and filters columns based on type in grid.plant so that if we are looking for just wind, or just wind_offshore, we don't get the other plants' profiles.

In test_curtailment.py: we modify tests so that they adequately test combinations of wind, solar, and wind_offshore.

Time to review

15 minutes. Besides columns selection in calculate_curtailment_time_series(), there's not much else going on.

[rouille]

PEP8 issue: the above line should be further indented

[danielolsen]

Modified to avoid this issue.

[rouille]

l. 108 in curtailment.py: should it be scenario-long instead of year-long in the docstring or something in that vein?

l. 55 and l. 174 in test_curtailment.py: ther should be 2 blank lines (PEP8)

[rouille]

In the following test:

    def _check_curtailment_vs_expected(self, curtailment, expected):
        self.assertIsInstance(curtailment, dict)
        self.assertEqual(curtailment.keys(), expected.keys())
        for key in curtailment.keys():
            self.assertIsInstance(curtailment[key], pd.DataFrame)
        assert_array_equal(curtailment[key].index.to_numpy(),
                           expected[key].index.to_numpy())
        assert_array_equal(curtailment[key].columns.to_numpy(),
                           expected[key].columns.to_numpy())
        assert_array_equal(curtailment[key].to_numpy(),
                           expected[key].to_numpy())

don't we want the three assert_array_equal to be within the for loop?

[rouille]

Sorry. Just realize now that I am not the reviewer. Stop here.

[danielolsen]

Sorry. Just realize now that I am not the reviewer. Stop here.

Comments addressed anyway 👍

[BainanXia]

Sorry. Just realize now that I am not the reviewer. Stop here.

You are welcome and feel free to keep going :)

[BainanXia]

All tests passed. Minimum changes to the existing code to support offshore wind curtailment calculations are made. This will be useful when we refactor the curtailment plot the AnalyzePG.