Merged
Conversation
segmentation code simplified, resulting in much faster plotting of lmps, important for website fix: size_factor remove print statements in lmp plot function, add size_factor for aesthetic improvement (ability to scale size of dots) in carbon mapping. fix: simplify plotting make map_risk_bind function plot either risk or bind map, depending on user input, rather than always plotting both feat: interconnections mapping fix: allow font change allow font size changes on the plot_states function, which is used to color code state by renewables goals or other variables fix: fix name of func in nb fix: lmp speed up segmentation code simplified, resulting in much faster plotting of lmps, important for website fix: size_factor remove print statements in lmp plot function, add size_factor for aesthetic improvement (ability to scale size of dots) in carbon mapping. fix: simplify plotting make map_risk_bind function plot either risk or bind map, depending on user input, rather than always plotting both feat: interconnections mapping fix: allow font change allow font size changes on the plot_states function, which is used to color code state by renewables goals or other variables fix: fix name of func in nb
merrielle
approved these changes
Jul 2, 2020
Collaborator
merrielle
left a comment
merrielle
left a comment
There was a problem hiding this comment.
This looks awesome! I just had a couple questions and some minor variable name suggestions. Feel free to merge once you take a look at those.
victoriahunt
force-pushed
the
map_improvement
branch
from
a641727 to
4c5bec0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the purpose of the code feature: Bokeh maps of multiple types need to be uploaded to blob storage for use on the website. This PR relates to Zenhub issue PostReise #128 . Note that there is an accompanying PR in CENACS to implement the changes in the notebook that uses these code changes in plotting functions.
What the code is doing: New code to create a map of all transmission color coded by interconnection. Improved code for 6 other types of plots that are planned to be used on the website including carbon emissions and lmp maps. LMP map is also significantly sped up by implementing data segmenting through a pandas data frame rather than through indexing for color coding by value.
How urgent is this?: Not particularly urgent, but does contribute to meeting our timeline for the website soft launch this summer. I expect it takes an hour to review. Commits have already been squashed and branch has been rebased prior to PR submission.