Conversation
|
I presume the deleted notebooks are no longer used, right? |
| "nuclear": "Nuclear", | ||
| "geothermal": "Geothermal", | ||
| "coal": "Coal", | ||
| "dfo": "Fuel Oil", |
There was a problem hiding this comment.
Noticed a couple of the labels are different from the ones added in your other PR, mainly dfo and storage. Just making sure this was on purpose.
There was a problem hiding this comment.
I decided to use your labeling, the one you had in the summarize module. I believe that you came up with this labeling in order to match the column name in the historical generation excel file that you load in your notebook.
I am not sure this is the best labeling though, I prefer Fuel Oil in place of DFO. We cn change that later.
One thing I don't like is to rely on excel file for the historical data (generation, demand, etc.). I would prefer to have a module that enclose dictionaries with these numbers, e.g. generation = {"Washington": {"coal": x, "ng": y, ...}, "Idaho": {"Coal": z, ...}}. We use these numbers in several places, they need to be version controlled and easily accessible.
There was a problem hiding this comment.
Yeah I think I used a copy from the notebook without realizing there were multiple versions - I also prefer Fuel Oil to DFO. Anyway sounds good, we can come back to this later.
Yes. those were using scenarios we ran for the February 2018 review and their analysis was very specific. |
BainanXia
left a comment
There was a problem hiding this comment.
I think for now this is good to go.
Purpose
Use the newly created powersimdata/network/usa_tamu/constants/plants.py module in the analysis and plotting modules of PostREISE. See Breakthrough-Energy/PowerSimData#267.
What is the code doing?
Use dictionaries defined in powersimdata/network/usa_tamu/constants/plants.py in place of dictionaries defined in some module (e.g.
summarize.pyandanalyze_pg.py). Refactor modules that were using theGridclass to access generators' constants.Where to look
Several modules were concerned in postreise/analyze/generation/ and postreise/plot/. Note that I did not refactor the code postreise/plot/multi/ for sevaeral reasons:
AnalyzePGobjects are used and hence the code will have to be refactored once we break apart theAnalyzePGclassconstants.pymodule making the code very specific.In other words, a more extensive refactoring is necessary and beyond the scope of this PR.
Time estimate
10 min