Merged
Conversation
Collaborator
|
It looks good. Can we wait that @victoriahunt's PR and mine is merged before merge it? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Various changes to improve the workflow.
What it does
Note - for anyone looking closely, we are keeping the python version matrix instead of combining all the workflows into one and limiting to the latest python3 like we did in powersimdata. The reason is to have better support for the package when it's publicly available, since at least for now that will be the distribution mechanism (as opposed to hosted/container/etc). We have only one version for the formatting workflow since that doesn't need to run the code. If this sounds good, the plan is to do the same for powersimdata.
Time to review
10 min - mostly small independent changes, with the bulk of the diff being import sorting