LMP Map: hover tips and web compatibility for mapping visualization#191
Merged
victoriahunt merged 1 commit intodevelopfrom Nov 17, 2020
Merged
LMP Map: hover tips and web compatibility for mapping visualization#191victoriahunt merged 1 commit intodevelopfrom
victoriahunt merged 1 commit intodevelopfrom
Conversation
rouille
reviewed
Nov 6, 2020
| @@ -112,30 +108,45 @@ def _construct_shadowprice_visuals(lmp_split_points, bus_segments, us_states_dat | |||
| :type file_name: str | |||
| """ | |||
Collaborator
There was a problem hiding this comment.
The docstring is not up to date. The file_name parameter should be discarded and and return parameter should be added. Also, it would be nice to use our more condensed docstring formatting that we use in other modules:
- :param type
param_name:description - :return: (type) --
description
victoriahunt
force-pushed
the
lmp_visuals_improve_vh
branch
2 times, most recently
from
cff8c35 to
bd45f27
Compare
rouille
reviewed
Nov 17, 2020
| :type file_name: str | ||
| :param us_states_dat: if None default to us_states data file, imported from bokeh | ||
| :type us_states_dat: dict | ||
| :param pandas.DataFrame s_grid: scenario grid |
Collaborator
There was a problem hiding this comment.
:param powersimdata.input.grid.Grid s_grid:
victoriahunt
force-pushed
the
lmp_visuals_improve_vh
branch
from
a615180 to
af4b765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette doc
Purpose
Add hover-over tips and improve web compatibility of the LMP mapping functions, which are used on the website dashboard. Addresses zenhub issue #190
What the code is doing
Hover tips added in plot_lmp_map.py. Aesthetic improvements added including making lines of state borders gray instead of black. Also aligns with other maps on dashboard stylistically.
Testing
n/a
Where to look
plot_lmp_map.py
Usage Example/Visuals
Showing hover over tips. Visualizing lmp for scenario 824.
Zoomed out to whole USA:
Time estimate
10-15 min.