refactor: remove redundant map_demand_to_buses#208
Merged
danielolsen merged 4 commits intodevelopfrom Feb 5, 2021
Merged
Conversation
BainanXia
reviewed
Feb 5, 2021
BainanXia
approved these changes
Feb 5, 2021
Collaborator
BainanXia
left a comment
There was a problem hiding this comment.
The test refactor is clever. Thanks.
Contributor
Author
I don't remember how I learned that monkeypatch exists, but @jon-hagg used it in PowerSimData so maybe that was it. I think there are many places in our code that could benefit from this, places where our main code is complex to make testing easy, and it would be better to make the main code simple and do something like this for the tests. |
c6dd0d6 to
1bd1011
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
unittesttopytestto get tomonkeypatchfunctionality (& general succinctness)InputData.get_datamethod which relies on profile CSVs. (see https://docs.pytest.org/en/stable/monkeypatch.html)Time estimate
10 minutes, mostly for understanding the test changes.