Merged
Conversation
kasparm
reviewed
Aug 7, 2019
Contributor
kasparm
left a comment
kasparm
left a comment
There was a problem hiding this comment.
Do we need to add posixpath to the requirements?
Collaborator
Author
|
No, posixpath is part of the standard library. It does the same thing than os.path but is not OS dependent, all paths will be for UNIX type of OS. |
kasparm
approved these changes
Aug 7, 2019
rouille
force-pushed
the
windows_compatible
branch
from
53ebd8a to
f45a434
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set path to POSIX pathname every time a UNIX command is called from local machine to run on server. This should resolve the issue users having a Windows OS encounters when communicating with the server (Linux OS).