Skip to content

fix: double-extracting congestion lower, not extracting upper#24

Merged
kasparm merged 1 commit intodevelopfrom
fix_congu_extraction
Aug 15, 2019
Merged

fix: double-extracting congestion lower, not extracting upper#24
kasparm merged 1 commit intodevelopfrom
fix_congu_extraction

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 13, 2019

Fixing a typo, see #23 for a description of the problem, and https://github.com/MATPOWER/matpower/blob/master/lib/idx_brch.m for more info on what we are extracting from the matpower solution.

This is needed for congestion and solar curtailment analysis.

@ghost ghost requested review from kasparm and rouille August 13, 2019 18:31
@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Aug 13, 2019

Did you test the change on a MATLAB output file?

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 13, 2019

Yes, the change extracts a matrix of the same dimension but with different values (as expected).

Copy link
Copy Markdown
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the merge, I will need to delete the current outputs and re-extract the data. @kasparm, can you look at this PR when you have a sec. I believe @danielolsenIV needs the new file for data analysis. Thanks

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 13, 2019

Deleting and re-analyzing is not urgent, I've managed to do the extraction locally and I am doing analysis based on these files. I could also scp the updated pickle files back to the server if that's easier than deleting and re-analyzing.

@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Aug 13, 2019

You downloaded all 61 MATLAB files from the server and did the extraction on your laptop? It is not very complicated to re-extract the files. I will do it once the PR is approved and the changes are checkout on the server. No worries.

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 13, 2019

I did exactly that. I am very curious to solve this problem and didn't want to wait any longer than I had to!

I also made one more small fix, I had improperly specified which one was the 'upper' limit dual var and which one was the 'lower' limit dual var (the MATPOWER documentation is quite vague), this is fixed now.

@ghost ghost self-assigned this Aug 14, 2019
@kasparm kasparm force-pushed the fix_congu_extraction branch from 3987166 to 5738812 Compare August 15, 2019 00:02
@kasparm kasparm merged commit 5738812 into develop Aug 15, 2019
@ghost ghost removed their assignment Oct 29, 2019
@danielolsen danielolsen deleted the fix_congu_extraction branch July 11, 2020 03:02
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants