Merged
Conversation
Collaborator
|
Collaborator
There is a _check_time_series function! |
Contributor
Author
|
Collaborator
|
Contributor
Author
|
BainanXia
approved these changes
Mar 23, 2021
Collaborator
BainanXia
left a comment
There was a problem hiding this comment.
This is good to go. Thanks!
Collaborator
|
Should we move the plt.show() inside the function? |
Contributor
Author
I think this is a larger conversation about what we want our plot functions to ultimately do: return a plot, or display a plot. I think right now we have a mixture, but it would be nice to standardize. |
28f702d to
f15c6fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add this plot, which has been used fairly extensively in the Macro Grid report, to the codebase.
What the code is doing
The code is mostly just passing appropriate parameters to other functions, and orchestrating the creation of a plot figure.
Usage Example/Visuals
Default behavior, using summed curtailment for an Ambitious scenario:
If we flip the colorbar colors:
..and then we want to plot in GW, rather than MW:
...and then we want to explicitly set the range to 250 GW, with updated labels to match:
...and then we want to translate from UTC to CST:
...and then we also want to add a contour for the saturated area:
etc.
Time estimate
15 minutes.