Merged
Conversation
rouille
reviewed
Apr 3, 2021
ab8f804 to
9c63516
Compare
Collaborator
|
All the other notebooks file name in the demo finish with |
9c63516 to
cba41af
Compare
cba41af to
c2ce32e
Compare
Collaborator
Author
Done. |
rouille
approved these changes
Apr 5, 2021
Collaborator
rouille
left a comment
There was a problem hiding this comment.
The notebook runs smoothly and the code looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Integrate another plot function from spot check notebook: scatter plot capacity vs curtailment
What the code is doing
plot_scatter_capacity_vs_curtailment.Testing
No tests is added. The plot function calls existing functions in
analyzemodule for calculations.Where to look
Usage Example/Visuals
Demos can be found in the demo notebook.
Time estimate
10 min. It is similar with
plot_scatter_capacity_vs_capacity_factor.