Skip to content

scatter capacity vs curtailment#256

Merged
BainanXia merged 2 commits intodevelopfrom
bainan/scatter_capacity_curtailment
Apr 5, 2021
Merged

scatter capacity vs curtailment#256
BainanXia merged 2 commits intodevelopfrom
bainan/scatter_capacity_curtailment

Conversation

@BainanXia
Copy link
Copy Markdown
Collaborator

@BainanXia BainanXia commented Apr 2, 2021

Pull Request doc

Purpose

Integrate another plot function from spot check notebook: scatter plot capacity vs curtailment

What the code is doing

  • Implement plot function plot_scatter_capacity_vs_curtailment.
  • Add demo notebook for the new plot function.

Testing

No tests is added. The plot function calls existing functions in analyze module for calculations.

Where to look

/postreise/plot/plot_scatter_capacity_vs_curtailment.py
/postreise/plot/demo/scatter_capacity_vs_curtailment_demo.ipynb

Usage Example/Visuals

Demos can be found in the demo notebook.

Time estimate

10 min. It is similar with plot_scatter_capacity_vs_capacity_factor.

@BainanXia BainanXia added the visualization Issue related to visualization label Apr 2, 2021
@BainanXia BainanXia requested review from danielolsen and rouille April 2, 2021 22:47
Comment thread postreise/plot/plot_scatter_capacity_vs_curtailment.py Outdated
@BainanXia BainanXia force-pushed the bainan/scatter_capacity_curtailment branch from ab8f804 to 9c63516 Compare April 3, 2021 13:55
@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Apr 5, 2021

All the other notebooks file name in the demo finish with _demo. Do we want to rename postreise/plot/demo/scatter_capacity_vs_curtailment.ipynb for consistency?

@BainanXia BainanXia force-pushed the bainan/scatter_capacity_curtailment branch from 9c63516 to cba41af Compare April 5, 2021 20:54
@BainanXia BainanXia force-pushed the bainan/scatter_capacity_curtailment branch from cba41af to c2ce32e Compare April 5, 2021 20:58
@BainanXia
Copy link
Copy Markdown
Collaborator Author

All the other notebooks file name in the demo finish with _demo. Do we want to rename postreise/plot/demo/scatter_capacity_vs_curtailment.ipynb for consistency?

Done.

Copy link
Copy Markdown
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook runs smoothly and the code looks good

@BainanXia BainanXia merged commit 11d85cb into develop Apr 5, 2021
@BainanXia BainanXia deleted the bainan/scatter_capacity_curtailment branch April 5, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

visualization Issue related to visualization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants