fix: Set correctly the columns name in data frame#36
Merged
Conversation
kasparm
reviewed
Sep 18, 2019
| pass | ||
|
|
||
| for k, v in outputs_id.items(): | ||
| try: |
Contributor
There was a problem hiding this comment.
Not sure try is best practice for the case when you don't know the case.
Just a detail.
Collaborator
Author
There was a problem hiding this comment.
Ok. I can do a if/else based on type then. Would it work for you?
Collaborator
Author
There was a problem hiding this comment.
This has been implemented. The rebase has been done.
rouille
force-pushed
the
dataframeid
branch
from
a6d202f to
a3acfca
Compare
kasparm
approved these changes
Sep 18, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fix an issue when a data frame only has one column.