Changes to AnalyzePG

[rouille]

• Storage is added to stack and chart plots.
• Solar and wind curtailments are added to stack plot (from @dmuldrew).
• Mean curtailment is added to curtailment plot (from @dmuldrew).

Changes can be seen running the following code:

from powersimdata.scenario.scenario import Scenario
from postreise.plot.analyze_pg import AnalyzePG as apg

s = Scenario('160')
s.state.print_scenario_info()
s.state.print_infeasibilities()

# CHART
chart = apg(s,
            (s.info['start_date'], s.info['end_date'], 'utc', 'H'),
            ['Washington', 'Oregon', 'California', 'Nevada', 'Arizona', 'Utah',
             'New Mexico Western', 'Colorado', 'Wyoming', 'Idaho',
             'Montana Western', 'El Paso', 'Western'],
            ['nuclear', 'hydro', 'coal', 'ng', 'solar', 'wind', 'geothermal', 'storage'],
            'chart', normalize=False)
chart.get_plot(save=False)

# GENERATION
stack = apg(s,
            ('2016-04-23 00:00:00', '2016-04-28 23:00:00', 'local', 'H'),
            ['California', 'Western', 'Wyoming'],
            ['nuclear', 'hydro', 'coal', 'ng', 'solar', 'wind', 'geothermal', 'storage'],
            'stacked', normalize=False)
stack.get_plot(save=False)

# CURTAILMENT
curtailment = apg(s,
                  (s.info['start_date'], s.info['end_date'], 'utc', 'W'),
                  ['California', 'Western'],
                  ['solar'],
                  'curtailment', normalize=False)
curtailment.get_plot(save=False)

[merrielle]

This looks good. I have a lot of ideas for updating the rest of the file but they're not related to the changes you're making here. If you can merge this into develop soon then I can start adding in the code from spot check.

By the way, I clicked "approve" because even though I had some comments the changes are very small. That means once you make the changes as long as they work you can merge without showing them to me. If I had clicked "request changes" it would mean you should show me your changes to get another round of feedback.

Anyway, as they say in the software world, ship it! 👍

[merrielle]

Small nitpick: could you rename this to storage_ids? I think it's easier to understand.

[rouille]

I can but the function returns the power generated by all storage devices in zone and the corresponding total capacity.

[merrielle]

This method works just fine, but I think you can use a where clause here.
storage_ids = self.grid.bus.where(id in self.grid.storage.gen.bus_id & id in self._get_zone_id(zone))
I kind of fudged the table locations but I think you get the general idea.

If you're feeling rushed don't worry about figuring this out, but keep it as an idea for next time.

[rouille]

Agree. I will implement this tomorrow

[merrielle]

How does this work?

[rouille]

Not sure. It is from @dmuldrew. I believe it set the tick mark and tick label to month-year (e.g. Jan 2016, Feb 2016, ...)

[merrielle]

Let's optimize some duplicate code here. Do you think this would work?

# Add solar and wind curtailment
for (t, key) in [('solar', 'sc'), ('wind', 'wc')]:
    if t in type2label.keys():
        pg_t = self._get_pg(zone, [t])[0].sum(axis=1)
        net_demand['net_demand'] = net_demand['net_demand'] - pg_t
        curtailment_t = self._get_profile(zone, t).sum(axis=1).tolist() - pg_t
        pg_stack[key] = curtailment_t

[rouille]

Yes it should. I will implement it tomorrow.

Do not hesitate to make changes and commit. I would say it is preferable that you do it it now instead of merging now, then creating a new branch wit a new PR and CR.