Skip to content

feat: parse change_table entries into interstate/intrastate#42

Merged
rouille merged 1 commit intodevelopfrom
interstate_intrastate
Nov 11, 2019
Merged

feat: parse change_table entries into interstate/intrastate#42
rouille merged 1 commit intodevelopfrom
interstate_intrastate

Conversation

@danielolsen
Copy link
Copy Markdown
Contributor

This branch adds a new script analyze/statelines.py to parse a change_table (with a grid) into lists of upgraded interstate and intrastate lines, with a corresponding test_statelines.py script. This testing functionality uses several testing tools added in the PR for carbon (#39): the tests/ folder in root, the context.py file to ensure that the tests always import the right version of PostREISE, and the mock objects in mocks.py.

@danielolsen
Copy link
Copy Markdown
Contributor Author

The unit tests test the individual functions with the mocks. An integration test against the real object can be run as:

from powersimdata.scenario.scenario import Scenario
from postreise.analyze.statelines import classify_interstate_intrastate
scenario = Scenario('130')
classified = classify_interstate_intrastate(scenario)
print(classified)

@rouille rouille force-pushed the interstate_intrastate branch from 9161be7 to d2c4d4d Compare November 11, 2019 22:31
Copy link
Copy Markdown
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rouille rouille merged commit 20189bd into develop Nov 11, 2019
@rouille rouille deleted the interstate_intrastate branch November 11, 2019 23:03
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants