feat: add plot tornado function and state mappers from spot check#66
feat: add plot tornado function and state mappers from spot check#66
Conversation
|
The following test fails for me. Maybe I am doing something wrong: |
|
Is there a demo that shows how to use this? If not, I think would be helpful to add a quick demo. |
|
4 of the 9 test in postreise/plot/tests failed for me. I'm still learning about testing - maybe it's an error on my side? In summary, the tornado plot code seemed to work well for me and looked good in review, but these tests are not all passing. |
|
@victoriahunt I ran into the |
6c82e77 to
eae0805
Compare
|
@victoriahunt I added a demo notebook! I fixed the broken tests in this pr #68. It's already been merged so if you update PostREISE the tests in |
|
All tests passed. Heads up that I did get 3 warnings on tests which were all the same issue and read as follows: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working from collections import Mapping. Thanks for adding the demo. |
victoriahunt
left a comment
There was a problem hiding this comment.
Tornado plot will be useful and the demo is helpful in showing the basics of how it works. All tests are passing.

This code is adding the most useful bits from the most recent spot check notebooks. It has plotting code to gracefully show a horizontal bar graph with both positive and negative values.
It also adds some dictionaries to help map state abbreviations to state names and also loadzones to states.EDIT: The dictionaries have been moved to PreREISE.
Ideally the PR should be quick and easy. :)