Conversation
danielolsen
approved these changes
Jan 31, 2020
Contributor
danielolsen
left a comment
danielolsen
left a comment
There was a problem hiding this comment.
Looks straightforward.
rouille
force-pushed
the
use_pmin_pmax
branch
from
604d194 to
c3c1c6c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
GenMWMax --> Pmax wherever it is encountered in the package. Also, the
MockGridobject has been in PowerSimData. As a result, import statements have been updated and the file enclosing theMockGridobject removed from PostREISE. See #67.Note that this PR depends on the new grid design (Grid Building PR in PowerSimData). It will be merged once the Grid Building PR is approved.