Conversation
add 'hydro' into mock_analyze.py add 'solar' 'wind' and 'hydro' profile tests in test_mocks.py
danielolsen
reviewed
Feb 20, 2020
|
|
||
| def get_hydro(self): | ||
| """Get hydro. | ||
| :return: (pandas.DataFrame) -- dummy wind |
Collaborator
Author
There was a problem hiding this comment.
I fixed it in the latest commit however it is not published. First time using PyCharm windows, sometimes the latest commit does not go through. I should have checked it before submit the PR. Good catch.
danielolsen
reviewed
Feb 20, 2020
| grid_attrs={'plant': mock_plant}, | ||
| solar=self.mock_solar) | ||
| solar = scenario.state.get_solar() | ||
| err_msg = 'solar profile should have dimension (periodNum * len(plant))' |
Contributor
There was a problem hiding this comment.
solar/wind/hydro here should not match dimension of plant, they should match dimension of the number of gens of that type within plant. The code looks good, it's just the error message that needs changing.
Collaborator
Author
There was a problem hiding this comment.
Same here. I made the changes in the commit that does not go through. It shows up now.
danielolsen
reviewed
Feb 20, 2020
| inplace=True) | ||
| self.mock_pg.index.name = 'UTC' | ||
|
|
||
| solar_plant_id = [plant_id for i, plant_id in enumerate(mock_plant['plant_id']) if mock_plant['type'][i] == 'solar'] |
Contributor
There was a problem hiding this comment.
Let's wrap these lines to get down to 79 chars.
danielolsen
approved these changes
Feb 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add 'hydro' into mock_analyze.py
add 'solar' 'wind' and 'hydro' profile tests in test_mocks.py
This PR is just one commit to add hydro into mock scenario object so that 'ScenarioInfo' object could be tested using mock scenario.