feat: add info attribute to MockScenario#83
Merged
Conversation
ScenarioInfo object needs to populate the 'info' attribute from Scenario object, which does not exist in MockScenario oject and it fails the corresponding tests.
danielolsen
approved these changes
Mar 18, 2020
Contributor
danielolsen
left a comment
danielolsen
left a comment
There was a problem hiding this comment.
All tests pass on PowerSimData and PostREISE.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ScenarioInfo object needs to populate the 'info' attribute from Scenario object, which does not exist in MockScenario object and it fails the corresponding tests.
What is the code doing
Add a dummy 'info' attribute to MockScenario.
Add some missing docs in MockAnalyze.
Where to look
It is a one line change.
Time estimate
Very quick.