fix: ensure that MockAnalyze returns a dict for ct#84
Merged
danielolsen merged 1 commit intodevelopfrom Mar 20, 2020
Merged
Conversation
rouille
approved these changes
Mar 20, 2020
Collaborator
rouille
left a comment
rouille
left a comment
There was a problem hiding this comment.
It is consistent with the value returned by the get_ct method of the Analyze object when there is no change table. The returned value is set in the constructor of the Scaler object.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make sure that MockAnalyze returns a dictionary when we ask for the change table, even if we don't actually provide one to the object on init. This is needed for the tests for the feature that addresses Breakthrough-Energy/PowerSimData#116
What is the code doing?
If given
Nonefor thectparam, return{}on callingget_ct().Time Estimate
It is one line.