Conversation
…into addAnalyzeAndPlot
…unction of scenarios
…ed renewable energy in a given grid
…d annotate some plots
kasparm
approved these changes
Jan 16, 2019
Contributor
kasparm
left a comment
kasparm
left a comment
There was a problem hiding this comment.
Great work!
Here some things to consider in order to improve your coding style for the future:
- Try to use meaningful variable names as much as possible.
- Try to avoid using the line-break sign as much as possible by introducing meaningful variable names and using these variable names to conduct the operation.
- When doing line breaks, put the operation sign at the beginning of the line.
| @@ -0,0 +1 @@ | |||
|
|
|||
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have developed in the plot module. There, you will find the various analysis of the PG data I have produced. Check the README and the demo folder in plot. @mlamherr and @kasparm will need to include/clean their most recent developments on the congestion analysis.