Calculate averaged congestion and save file on server#92
Merged
Conversation
rouille
added
congestion
data collection
danielolsen
reviewed
Mar 27, 2020
| congl = pd.DataFrame({'bart': [1, 2, 3, 4], 'lisa': [10, 11, 12, 13]}) | ||
| congu = pd.DataFrame({'bart': [21, 22, 23, 24], 'lisa': [30, 31, 32, 33]}) | ||
| mean_cong = calculate_averaged_congestion(congl, congu) | ||
| assert np.array_equal(mean_cong.values, [[ 2.5, 22.5], [11.5, 31.5]]) |
Contributor
There was a problem hiding this comment.
PEP8 [[ 2.5, 22.5] -> [[2.5, 22.5]
Collaborator
Author
There was a problem hiding this comment.
I thought it was the missing line at the end of file! Ok. I fix it, interactive rebase and force push.
danielolsen
approved these changes
Mar 27, 2020
Contributor
danielolsen
left a comment
danielolsen
left a comment
There was a problem hiding this comment.
There's the tiniest PEP8 bug, other than that it looks good to go.
rouille
force-pushed
the
calculate_averaged_cong
branch
from
78afd74 to
96960de
Compare
rouille
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A data frame enclosing the averaged CONGU and CONGL for each branch is written as a pickle file on the server In addition to the other usual simulation outputs.
What is the code doing
It calculates the averaged congestion via the
calculate_averaged_congestionin the postreise.extract.extract_data module. The function is then used to save the returned data frame as pickle file.Tests have been written in postreise.extract.tests.test_extract_data.
Time estimate
Should be fairly quick. A 24h test scenario could be created, ran and extracted to make sure the file is correctly saved.
Note
The procedure that download/load in the Scenario object this file still need to be implemented in PowerSimData.