Skip to content

Move modules#97

Merged
rouille merged 4 commits intodevelopfrom
move_modules
Apr 10, 2020
Merged

Move modules#97
rouille merged 4 commits intodevelopfrom
move_modules

Conversation

@rouille
Copy link
Copy Markdown
Collaborator

@rouille rouille commented Apr 8, 2020

Purpose

Clean the PostREISE package after moving modules in the REISE and PowerSimData packages:

  • server connection and data transfer: postreise/process/ --> powersimdata/utility/ in PowerSimData.
  • data extraction server side: postreise/extract/ --> pyreise/utility/ in REISE.

What is the code doing?

Nothing. postreise/process/ and postreise/extract/ have been removed in PostREISE, the requirements and README have been updated.

Where to look?

The general structure of the package and the README.

Time estimate

30 minutes.

Note

A scenario has been successfully run using the new strucure where postreise/process/ and postreise/extract/ were not used. This PR is about cleaning after moving modules.

@rouille rouille added the new feature Feature that is currently in progress. label Apr 8, 2020
@rouille rouille added this to the Cherry Blossom milestone Apr 8, 2020
@rouille rouille requested review from danielolsen and kasparm April 8, 2020 19:09
@kasparm
Copy link
Copy Markdown
Contributor

kasparm commented Apr 9, 2020

Please remove the data copy statement in setup.py:
package_data={'postreise': ['extract/*.m']},

@rouille
Copy link
Copy Markdown
Collaborator Author

rouille commented Apr 9, 2020

good catch

@rouille rouille merged commit 2bf89db into develop Apr 10, 2020
@rouille rouille deleted the move_modules branch April 10, 2020 00:35
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Feature that is currently in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants