Skip to content

Importer add studyType to Study#100

Merged
nickpalladino merged 1 commit intodevelopfrom
bug/studyType
Aug 13, 2021
Merged

Importer add studyType to Study#100
nickpalladino merged 1 commit intodevelopfrom
bug/studyType

Conversation

@nickpalladino
Copy link
Member

Breedbase POST /studies requires the studyType field to be set so adding it as a required field to the importer for the Study object.

@github-actions github-actions bot added the bug Something isn't working label Aug 13, 2021
"Variety Release Trial, Clonal Evaluation, Advanced Yield Trial, crossing_trial, " +
"grafting_trial, pollinating_trial, phenotyping_trial, genotyping_trial, " +
"Seed Multiplication, Screen House, crossing_block_trial, Specialty Trial, etc.")
private String studyType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove misc_trial from the list. That's an internal breedbase thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, I wasn't sure about that since it's showing up in the trial design as an option in the breedbase GUI. I grabbed all the terms from the db and looks like there's a few extra compared to the GUI.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you still think I should remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Yeah I had to put in a trial type of misc_trial whose cvterm value is recorded as the type the user passes in. In brapi it returns whatever the user enters and doesn't show misc_trial. So I guess we could show it, I just wonder if it is useful to anyone. I guess these help texts will all need a pass through by Shawn to clean them up anyway, so you can probably just leave it for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good thanks.

@nickpalladino nickpalladino merged commit a431c35 into develop Aug 13, 2021
@nickpalladino nickpalladino deleted the bug/studyType branch August 13, 2021 14:48
timparsons pushed a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants