Merged
Conversation
ctucker3
suggested changes
Aug 13, 2021
| "Variety Release Trial, Clonal Evaluation, Advanced Yield Trial, crossing_trial, " + | ||
| "grafting_trial, pollinating_trial, phenotyping_trial, genotyping_trial, " + | ||
| "Seed Multiplication, Screen House, crossing_block_trial, Specialty Trial, etc.") | ||
| private String studyType; |
Contributor
There was a problem hiding this comment.
I would remove misc_trial from the list. That's an internal breedbase thing.
Member
Author
Member
Author
There was a problem hiding this comment.
Let me know if you still think I should remove it.
Contributor
There was a problem hiding this comment.
Oh I see. Yeah I had to put in a trial type of misc_trial whose cvterm value is recorded as the type the user passes in. In brapi it returns whatever the user enters and doesn't show misc_trial. So I guess we could show it, I just wonder if it is useful to anyone. I guess these help texts will all need a pass through by Shawn to clean them up anyway, so you can probably just leave it for now.
Member
Author
There was a problem hiding this comment.
ok sounds good thanks.
HMS17
approved these changes
Aug 13, 2021
ctucker3
approved these changes
Aug 13, 2021
timparsons
pushed a commit
that referenced
this pull request
Sep 29, 2021
Importer add studyType to Study
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breedbase
POST /studiesrequires the studyType field to be set so adding it as a required field to the importer for the Study object.