Skip to content

[BI-1157] Allow for imports to not be connected to a program#106

Merged
ctucker3 merged 4 commits intodevelopfrom
feature/BI-1157
Oct 27, 2021
Merged

[BI-1157] Allow for imports to not be connected to a program#106
ctucker3 merged 4 commits intodevelopfrom
feature/BI-1157

Conversation

@ctucker3
Copy link
Contributor

@ctucker3 ctucker3 commented Oct 21, 2021

  • Changes the importer_mapping table in the database to remove the program_id.
    • Adds a new table importer_mapping_program that now stores the import to program connection
    • System imports do not have a program attached and is how they are identified as system imports.
  • Adds an endpoint to get system imports.
    • The endpoint allows searching by import name.
    • Program import queries were modified so they do not grab system imports.
  • A check was added in the create mapping endpoint so that program mappings don't use the same name as system mappings.
  • For saving data, all of the endpoints are the same.
  • Added tests for system mappings that also acts to test the same machinery that the program mappings use.
    • Creation of program mappings are also covered in the tests.

@ctucker3 ctucker3 marked this pull request as ready for review October 22, 2021 12:57
@nickpalladino nickpalladino requested a review from HMS17 October 22, 2021 13:35
return program;
}

@Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Importer tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahah yeah I was feeling ambitious that day :P

@ctucker3 ctucker3 merged commit 499500d into develop Oct 27, 2021
@ctucker3 ctucker3 deleted the feature/BI-1157 branch October 27, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants