Merged
Conversation
davedrp
requested review from
a team,
HMS17 and
timparsons
and removed request for
a team
HMS17
requested changes
Nov 23, 2021
| * limitations under the License. | ||
| */ | ||
|
|
||
| ALTER TABLE trait DROP COLUMN abbreviations ; No newline at end of file |
Contributor
There was a problem hiding this comment.
| else { | ||
| DataType datatype = scale.getDataType(); | ||
| if( datatype != null ) { | ||
| // is the dataType is not Numerical use the dataType value |
Contributor
There was a problem hiding this comment.
small thing, guessing you meant "if", not "is"
HMS17
approved these changes
Nov 29, 2021
timparsons
reviewed
Nov 30, 2021
| DataType datatype = scale.getDataType(); | ||
| if( datatype != null ) { | ||
| // if the dataType is not Numerical, use the dataType value | ||
| if(datatype!=DataType.NUMERICAL){ |
Member
There was a problem hiding this comment.
Does this mean that if the datatype is NUMERICAL that there will not be a scale name derived?
Contributor
Author
There was a problem hiding this comment.
Correct, the user is requried to provide the scale name (aka unit) if the datatype is NUMERIC.
timparsons
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://breedinginsight.atlassian.net/browse/BI-1158