Conversation
Contributor
Author
Contributor
Author
nickpalladino
requested changes
May 7, 2020
Member
nickpalladino
left a comment
nickpalladino
left a comment
There was a problem hiding this comment.
Tests pass and test cases cover the bug fix. Just an old duplicate line of code that should be removed.
| @@ -57,39 +59,7 @@ void setup() throws Exception { | |||
| testUser = userService.getByOrcid(TestTokenValidator.TEST_USER_ORCID).get(); | |||
| testUser = userService.getByOrcid(TestTokenValidator.TEST_USER_ORCID).get(); | |||
Member
There was a problem hiding this comment.
this line is in here twice
nickpalladino
approved these changes
May 8, 2020
timparsons
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This card pairs with INF-94 for bi-web and contains a fix to the /userinfo endpoint so that it returns roles now.