BI-1408 - ISSUE - All Germplasm Table stuck loading when connected with Breedbase#154
Merged
timparsons merged 3 commits intorelease/0.5from Mar 10, 2022
Merged
BI-1408 - ISSUE - All Germplasm Table stuck loading when connected with Breedbase#154timparsons merged 3 commits intorelease/0.5from
timparsons merged 3 commits intorelease/0.5from
Conversation
timparsons
requested review from
a team,
ctucker3 and
davedrp
and removed request for
a team
ctucker3
approved these changes
Mar 8, 2022
Contributor
ctucker3
left a comment
ctucker3
left a comment
There was a problem hiding this comment.
One small question that doesn't block review.
Tested against BreedBase and it loaded the cache right away after import, even with parents!
| <artifactId>mockito-core</artifactId> | ||
| <version>3.2.4</version> | ||
| <artifactId>mockito-inline</artifactId> | ||
| <version>3.10.0</version> |
Contributor
There was a problem hiding this comment.
Just wanted to check, this was needed for your test changes to the germplasm lists and wasn't an accidental commit?
Member
Author
There was a problem hiding this comment.
Yes, this dependency allows for using the static mocking built into mockito
…ad of raw germplasm
…rrect germplasm name in the BrAPI server
…display form of germplasm now
davedrp
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://breedinginsight.atlassian.net/browse/BI-1408
Refactored the germplasm cache to store the processed germplasm that bi-api will return instead of the raw germplasm that came from the BrAPI service storing the program's data.
Dependencies
bi-web - release/0.5
Testing
Please include any details needed for reviewers to test this code
Checklist: