INF-59 - Set appropriate logging configuration#19
Conversation
src/main/resources/logback.xml
Outdated
| </appender> | ||
|
|
||
| <root level="info"> | ||
| <logger name="org.breedinginsight" level="INFO"/> |
There was a problem hiding this comment.
Should we have the different levels of the debugger here? error, debug, info? The logs look the same as they did before, not a bad thing though. Not sure if they were supposed to look different?
There was a problem hiding this comment.
I'd recommend that we have our code be at DEBUG level, and all others (which would fall to the root level) be INFO.
There was a problem hiding this comment.
Sounds good. Changed org.breedinginsight logger level to DEBUG and pushed changes.
ctucker3
left a comment
There was a problem hiding this comment.
Looking for clarification on card purpose. Might be that @timparsons will want to get in on this discussion.
ctucker3
left a comment
There was a problem hiding this comment.
Chatted with Nick and saw the error of my ways. Everything looks good!
timparsons
left a comment
There was a problem hiding this comment.
Forgot to have my comment be as part of an official review...see my comment in logback.xml
Changes
Test Cases
Disable all framework logging and only see breeding insight logging
bi-api/src/main/resources/logback.xml, setroot level="OFF"INFOGET http://localhost:8081/v1/users/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaaDisable breeding insight logging and see only framework logging
bi-api/src/main/resources/logback.xml, setroot level="INFO"OFFGET http://localhost:8081/v1/users/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaaAcceptance Criteria