Skip to content

BI-2185 - Germplasm name validation "/"#459

Merged
nickpalladino merged 2 commits into
future/1.2from
feature/BI-2185
Apr 30, 2025
Merged

BI-2185 - Germplasm name validation "/"#459
nickpalladino merged 2 commits into
future/1.2from
feature/BI-2185

Conversation

@nickpalladino
Copy link
Copy Markdown
Member

@nickpalladino nickpalladino commented Apr 23, 2025 •
edited by atlassian Bot
Loading

Description

Story: BI-2185

  • Added validation for germplasm name not containing /

Dependencies

  • latest develop for brapi server

Testing

  • Ensure germplasm names containing / result in tabular validation errors

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino changed the title BI-2185 BI-2185 - BI-2185 Germplasm name validation "/" Apr 23, 2025
@nickpalladino nickpalladino changed the title BI-2185 - BI-2185 Germplasm name validation "/" BI-2185 - Germplasm name validation "/" Apr 23, 2025
@nickpalladino nickpalladino requested review from a team, HMS17 and davedrp and removed request for a team April 23, 2025 20:33
@HMS17 HMS17 self-assigned this Apr 25, 2025
HMS17
HMS17 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabular validation errors appear as expected

@nickpalladino nickpalladino marked this pull request as ready for review April 30, 2025 16:07
@nickpalladino nickpalladino merged commit 60ad8ba into future/1.2 Apr 30, 2025
2 checks passed
@nickpalladino nickpalladino deleted the feature/BI-2185 branch April 30, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davedrp davedrp davedrp approved these changes

@HMS17 HMS17 HMS17 approved these changes

Assignees

@HMS17 HMS17

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @davedrp @HMS17