Skip to content

BI-2694 - Field Book pulling sub-entity observation units#480

Merged
nickpalladino merged 2 commits into
developfrom
bug/BI-2694
Aug 1, 2025
Merged

BI-2694 - Field Book pulling sub-entity observation units#480
nickpalladino merged 2 commits into
developfrom
bug/BI-2694

Conversation

@nickpalladino
Copy link
Copy Markdown
Member

@nickpalladino nickpalladino commented Jul 18, 2025

Description

Story: BI-2694

  • No longer include empty treatments array in sub obs units additionalInfo
  • treatments will not work until Field Book json parsing issue is fixed

Dependencies

  • Field Book v6.2.5

Testing

  • Create an experiment with a sub-entity dataset. Import a field from the experiment into Field Book. Verify that the field imports without error.
  • Sub-entity datasets will not show up as selectable observation levels until the work Jason is doing on the BrAPI server is ready. Only existing observation levels like plot, plant, etc. will show up.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions Bot added the bug Something isn't working label Jul 18, 2025
@nickpalladino nickpalladino marked this pull request as ready for review July 31, 2025 20:15
@nickpalladino nickpalladino requested review from a team, HMS17, davedrp and dmeidlin and removed request for a team and dmeidlin July 31, 2025 20:27
Copy link
Copy Markdown
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tested locally and was able to pull in a sub-entity dataset with the "Plant" name!

@nickpalladino nickpalladino merged commit c58a7c3 into develop Aug 1, 2025
@nickpalladino nickpalladino deleted the bug/BI-2694 branch August 1, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants