Skip to content

BI-2820 Improve sample submission tabular error message#514

Merged
humsika merged 3 commits into
developfrom
feature/BI-2820
May 1, 2026
Merged

BI-2820 Improve sample submission tabular error message#514
humsika merged 3 commits into
developfrom
feature/BI-2820

Conversation

@davedrp
Copy link
Copy Markdown
Contributor

@davedrp davedrp commented Apr 30, 2026

Description

BI-2820 Improve sample submission tabular error message

Update Error message (and pass in only one variable).

Dependencies

bi-web: develop

Testing

  1. Import this Genotype Samples file sample_submission.csv (this assumes there is a valid Germplasm with GID=1)
  2. THEN: The tabular error Plate position not unique, duplicate in row 3 should appear.
  3. AND: The import should not happen.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@davedrp davedrp requested review from a team and humsika and removed request for a team April 30, 2026 15:53
@humsika
Copy link
Copy Markdown
Contributor

humsika commented May 1, 2026

Developer testing completed. Able to see the updated error message.

@humsika humsika merged commit ee7f4cd into develop May 1, 2026
1 check passed
@humsika humsika deleted the feature/BI-2820 branch May 1, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants