Skip to content

Apply BrAPI-server side Filtering/Sorting/Pagination to BI Experiments#521

Open
jloux-brapi wants to merge 7 commits into
feature/BI-2806from
feature/BI-2861
Open

Apply BrAPI-server side Filtering/Sorting/Pagination to BI Experiments#521
jloux-brapi wants to merge 7 commits into
feature/BI-2806from
feature/BI-2861

Conversation

@jloux-brapi
Copy link
Copy Markdown
Collaborator

Description

Story: BI-2861

To support the removal of the cache for TrialEntities, a generalized implementation of filtering and sorting was created for the prod server.

This body of changes modifies bi-api to utilize these new changes via search requests with the newly implemented SortBy and FilterBy request models that are now accessible via an updated brapi-java-client/model.

The changes to bi-api only affect Experiments/Trials, and should namely only really affect the data table seen in a Program's Experiments tab.

Included updates:

  • Upgrade to new brapi-java-client version
  • Pass ExperimentQuery parameters further into bi-api business logic so they can be handled by the brapi server
  • ExperimentQuery parameters now used to build BrAPISearchRequest which is used to call BrAPI Trials Search POST from java client.
  • Created generalized code for usage in other search requests in BrAPIDAOUtil
  • Created BrAPISortFilterMapper abstract class to be implemented by entities that need to be mapped. These implementations will define the mapping between the bi-web request names to the brapi-prod-server request names for the columns that need to be searched on
  • Updated unit tests to utilize the program search for experiments instead of the existing implementation which is used by the fe to filter. This will separate these concerns

Dependencies

Testing

  • Test filtering and sorting of Trials by messing around with the different functionalities of the data table in the Experiments tab of a Program. Mess with filtering, testing case insensitivity, and different data types. For sorting, test the order of different columns and ASC vs DESC order. Mess with paging, try selecting different pages, and different number of records per page

Checklist:

@jloux-brapi jloux-brapi changed the title Apply BrAPI-server side Filtering and Sorting to BI Experiments Apply BrAPI-server side Filtering/Sorting/Pagination to BI Experiments May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant