Skip to content

[BI-2878] Germplasm External UID missing from UI#472

Merged
jloux-brapi merged 1 commit into
developfrom
feature/BI-2878
Jun 10, 2026
Merged

[BI-2878] Germplasm External UID missing from UI#472
jloux-brapi merged 1 commit into
developfrom
feature/BI-2878

Conversation

@davedrp

@davedrp davedrp commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

BI-2878 Germplasm External UID missing from UI
Dependencies

bi-api: feature/BI-2878

Testing

  1. Import Germplasm with both a Seed Source and a External UID
  2. Go to Germplasm page (list of all Germplasm).
    Expected Result:
  • The External UID should be displayed for the newly imported Germplasm.
  1. Press the Lists tab.
  2. Press the Details link for the newly imported Germplasm List.
    Expected Result:
  • The External UID should be displayed for the newly imported Germplasm.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth
  • I have run SiteImprove on pages impacted by changes

@davedrp davedrp requested a review from jloux-brapi June 8, 2026 19:15

@jloux-brapi jloux-brapi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes as described look fine, and they test according to what is in the MR.

However, the UI displays this field as a sortable and filterable column, and the functionality does not work when used.

We should decide if we need that functionality, and if we do, fix it, or remove the functionality entirely from this column if it is not needed.

@jloux-brapi jloux-brapi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize there were bi-api changes, my apologies. I re-tests with those changes, and everything worked great.

@jloux-brapi jloux-brapi merged commit 3c7f404 into develop Jun 10, 2026
2 checks passed
@jloux-brapi jloux-brapi deleted the feature/BI-2878 branch June 10, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants