This repository was archived by the owner on Aug 1, 2025. It is now read-only.
BI-2078 - BrAPI-Java-TestServer OutOfMemoryError when saving ~30K Germplasm #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlm483
requested review from
a team,
davedrp and
nickpalladino
and removed request for
a team
nickpalladino
approved these changes
Mar 12, 2024
davedrp
approved these changes
Mar 19, 2024
davedrp
left a comment
davedrp
left a comment
There was a problem hiding this comment.
Developer test finished.
Seems to be about 4X faster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Story
Peter Selby made most of the code changes, I did the profiling. While more involved refactoring or schema changes could improve performance a lot, this change at least reduced the total memory footprint by an order of magnitude, hopefully it will make the
OutOfMemoryerror less likely.Testing
The file that originally produced the
OutOfMemoryerror is P1 0.9+649 0.9+673_germplasm_2024-02-29 02-14-36+0000.xlsx. Initially it would take about 100 minutes to upload locally, after the changes it takes around 40 minutes.