Fixed CSV exporting for image and folder modes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rows.append({'Filename': orig_name, 'EggsDetected': count}) | ||
| for uuid in all_results.keys(): | ||
| count = sum(1 for d in all_results[uuid] if d['score'] >= threshold) | ||
| rows.append({'Filename': filename_map[uuid], 'EggsDetected': count}) |
Member
There was a problem hiding this comment.
What do you think about adding a column for the confidence threshold as well? Seems like it would be good to have that metadata. May be a bit redundant to have in each row since they all with have the same threshold but don't think it's a big deal.
Contributor
Author
There was a problem hiding this comment.
That's an excellent idea, thanks Nick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSV export route (
'/export_csv') was non-functional for all modes.I fixed the
export_csv()function to parse through the .pkl files in the session's results folder, filter the detections to those with confidence >= the currently selected threshold, and format it into a CSV.I think we could simplify it by passing the results directly in the request, but if the export itself is not taking an excessive amount of time, I don't see this as very urgent
Export is working locally on my machine, have not tested inside Docker yet