Merged
Conversation
Remove nighwatch-api -- already stopped development. Update how the chrome browser is started since nightwatch can do it now. Modify the page creation. There is no more global client. The browser can be accessed using the this.browser. The page can be created using the this.browser.page.thisPage().
Upgrade library and methods.
Switch to waitelementPresent.
Add script line to generate report in case cucumber-js failed to make one. Call the report generator in the workflows.
cvacalares
requested review from
a team,
davedrp and
nickpalladino
and removed request for
a team
nickpalladino
approved these changes
Apr 30, 2025
davedrp
approved these changes
May 1, 2025
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: This is a big refactoring due to upgrading to latest nightwatchjs 3.12.
It also removed the usage of nighwatch-api due to improvements in nightwatchjs 3.12.
This iteration only supports chrome. Additional support for other browsers will be added later.
There are more code clean up and refactoring that needs to be done however, this is the initial step to quickly switch to the latest version.
The clean up and refactoring will be included in other automation work.
As a summary, on the this is the current (develop) test result.
This is the BI-2502 test result.
As you can see, more tests were passing.
Those failing tests are from existing bugs.
Dependencies
Testing
Please include a link to a successful run of TAF for this change
Checklist: