-
Notifications
You must be signed in to change notification settings - Fork 35
Multiple node groups #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Multiple node groups #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes issues with Euler rotation settings and removes some comments/declarations when unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changes
common_*module.exporthandles the logic of reading the node groups and spitting out Python codeuidefines configuration settings, as well as the UI layout of NodeToPythonNTP_OT_*operators are now removed in favor ofNodeTreeExporterclasses.NTP_OT_Export(export/ntp_operator.py) now sets up the options, initializes the files, and determines the node tree export order, which is important for resolving dependencies.NTP_OT_Exportthen delegates responsibility for actually exporting the node trees to individualNodeTreeExporters.node_tree_namesdictionary, which maps node tree creation functions to the node tree's assigned name after the function has been called. This avoid node tree duplication, while referencing node trees in a safe manner.typingto the list of standard modules to importUI
name_overrideoption to justname, as we can have multiple node groups potentiallyname("My Addon-on")export_iconis more appropriate, nowFILE_FOLDER(previouslyCONSOLE)locationis empty